Our recommended process for working with Polly is:
- Fork our repository on GitHub
- Clone your fork locally
- Configure the upstream (
git remote add upstream https://github.com/App-vNext/Polly.git)
- Switch to the default branch (i.e.
git checkout main
- Create a new local branch for your changes (
git checkout -b my-branch).
- Work on your changes
- Rebase if required (see below)
- Check that the solution builds successfully by running
dotnet testfrom the root of the repository
- There should be no errors or warnings
- All tests should pass
- The code coverage level is maintained
- Bug fixes should include at least one test where practical
- If adding new functionality, or checking existing behaviour, check whether there is any documentation that should be added or updated
- Push the branch up to GitHub (
git push origin my-branch)
- Create a Pull Request on GitHub - the PR should target (have as base branch) the default branch (i.e.
You should not work on a clone of the default branch, and you should not send a pull request from it - please always work from a branch. The reasons for this are detailed below.
Learning Git Workflow
Handling Updates from the default branch
While you're working away in your branch, it's possible that one or more new commits have been added to the repository's default branch. If this happens you should:
- Stash any uncommitted changes you need to
git checkout main
git pull upstream main
git checkout my-branch
git rebase main
- Sync your fork (optional) - this makes sure your remote main branch is up to date
This ensures that your history is "clean" i.e. you have one branch off from
main followed by your changes in a straight line. Failing to do this ends up with several "messy" merges in your history, which we don't want. This is the reason why you should always work in a branch and you should never be working in, or sending pull requests from,
Rebasing public commits is considered to be bad practice, which is why we ask you to rebase any updates from
If you're working on a long running feature then you may want to do this quite often, rather than run the risk of potential merge issues further down the line.
Sending a Pull Request
While working on your feature you may well create several branches, which is fine, but before you send a pull request you should ensure that you have rebased back to a single "feature branch" - we care about your commits, and we care about your feature branch; but we don't care about how many or which branches you created while you were working on it.
When you're ready to go you should confirm that you are up-to-date and rebased with upstream (see "Handling Updates from the default branch" above), and then:
git push origin my-branch
- Send a descriptive Pull Request on GitHub - making sure you have selected the correct branch in the GitHub UI.
It is not the end of the world if the commit history in your pull request ends up being messy - we can always squash it down to a single commit before merging. However, if you follow the steps above you should end up with a neater history.